pkg/daemon: Add IgnitionVersion to Daemon by LorbusChris · Pull Request #1729 · openshift/machine-config-operator

LorbusChris · 2020-05-12T21:30:04Z

Populate with output of ignition --version command
from locally installed binary.

This might be useful.

sinnykumari · 2020-05-13T07:50:48Z

Not against this but curious if we have any particular usecase where this will be useful? Knowing version of a binary should also be possible by mounting the desired OSContainer.

ashcrow

One nit to be reviewed. Other than that 👍

pkg/daemon/daemon.go

LorbusChris · 2020-05-13T14:10:13Z

CI already shows that this works:

daemon.go:225] Installed Ignition binary version: Ignition 0.35.1

(from: https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/1729/pull-ci-openshift-machine-config-operator-master-e2e-aws/7324/artifacts/e2e-aws/gather-extra/pods/openshift-machine-config-operator_machine-config-daemon-52q8c_machine-config-daemon.log )

I'll update per the suggestion above to only save the version number in the string.

Populate with output of `ignition --version` command from locally installed binary.

LorbusChris · 2020-05-13T14:23:28Z

Not against this but curious if we have any particular usecase where this will be useful? Knowing version of a binary should also be possible by mounting the desired OSContainer.

@sinnykumari my foremost reasoning for this is the following:
In RunFirstbootCompleteMachineconfig() we call canonicalizeEmptyMC(nil). In the ignition spec v2/v3 dual support case (from PR #1703) we wouldn't know what the canonical and supported one for the running system is that it has to create.

So the plan is to pass the version information into canonicalizeEmptyMC.

And additionally:
Over in #1703 I'm planning to add a field on the ControllerConfig to specify the requested spec version. If the requested version isn't the supported one, it would fail. However this is could actually be extended to fall back to the supported version no matter what is requested now that we have the ability to translate between versions.

sinnykumari · 2020-05-13T14:42:28Z

/lgtm

openshift-ci-robot · 2020-05-13T14:42:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, LorbusChris, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ashcrow,sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-05-13T15:48:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T16:01:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

ashcrow · 2020-05-13T16:21:39Z

/retest ci/prow/e2e-metal-ipi

openshift-ci-robot · 2020-05-13T16:21:53Z

@ashcrow: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

/test e2e-aws
/test e2e-aws-disruptive
/test e2e-aws-scaleup-rhel7
/test e2e-gcp-op
/test e2e-gcp-upgrade
/test e2e-metal-ipi
/test e2e-openstack
/test e2e-ovirt
/test e2e-vsphere
/test images
/test unit
/test verify

Use /test all to run all jobs.

Details

In response to this:

/retest ci/prow/e2e-metal-ipi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ashcrow · 2020-05-13T16:22:02Z

/retest e2e-metal-ipi

openshift-ci-robot · 2020-05-13T16:22:17Z

@ashcrow: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

/test e2e-aws
/test e2e-aws-disruptive
/test e2e-aws-scaleup-rhel7
/test e2e-gcp-op
/test e2e-gcp-upgrade
/test e2e-metal-ipi
/test e2e-openstack
/test e2e-ovirt
/test e2e-vsphere
/test images
/test unit
/test verify

Use /test all to run all jobs.

Details

In response to this:

/retest e2e-metal-ipi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LorbusChris · 2020-05-13T16:35:47Z

/test e2e-metal-ipi

openshift-bot · 2020-05-13T17:58:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T19:55:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T21:51:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T23:48:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-14T01:32:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-14T03:29:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-14T05:39:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-14T07:36:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-14T10:00:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-14T11:56:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-14T12:22:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

ashcrow · 2020-05-14T14:46:07Z

/test e2e-gcp-op

openshift-bot · 2020-05-14T16:42:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-01T15:33:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-01T17:04:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-01T18:48:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-01T22:16:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-01T22:55:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-02T00:13:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-02T00:52:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-02T03:28:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-02T04:20:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-02T05:38:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-02T08:14:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

LorbusChris · 2020-06-02T10:35:08Z

/retest

LorbusChris · 2020-06-02T14:41:13Z

/retest

openshift-bot · 2020-06-02T23:24:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-06-03T05:04:13Z

@LorbusChris: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws	`b823087`	link	`/test e2e-aws`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-06-03T05:28:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot requested review from ashcrow and runcom May 12, 2020 21:30

LorbusChris force-pushed the ign-version-daemon branch from b4a86fd to d527e2b Compare May 12, 2020 23:41

ashcrow reviewed May 13, 2020

View reviewed changes

pkg/daemon/daemon.go Outdated Show resolved Hide resolved

ashcrow requested a review from sinnykumari May 13, 2020 13:30

pkg/daemon: Add IgnitionVersion to Daemon

b823087

Populate with output of `ignition --version` command from locally installed binary.

LorbusChris force-pushed the ign-version-daemon branch from d527e2b to b823087 Compare May 13, 2020 14:12

ashcrow approved these changes May 13, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2020

openshift-ci-robot assigned sinnykumari May 13, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2020

ashcrow mentioned this pull request May 18, 2020

Add guidelines on PR + commit text openshift/enhancements#311

Merged

openshift-merge-robot merged commit 19c78b6 into openshift:master Jun 3, 2020

bgilbert mentioned this pull request Feb 24, 2021

Bug 1927731: Revert "pkg/daemon: Add IgnitionVersion to Daemon" #2431

Merged

Conversation

LorbusChris commented May 12, 2020

Uh oh!

sinnykumari commented May 13, 2020

Uh oh!

ashcrow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LorbusChris commented May 13, 2020

Uh oh!

LorbusChris commented May 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sinnykumari commented May 13, 2020

Uh oh!

openshift-ci-robot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

ashcrow commented May 13, 2020

Uh oh!

openshift-ci-robot commented May 13, 2020

Uh oh!

ashcrow commented May 13, 2020

Uh oh!

openshift-ci-robot commented May 13, 2020

Uh oh!

LorbusChris commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 13, 2020

Uh oh!

openshift-bot commented May 14, 2020

Uh oh!

openshift-bot commented May 14, 2020

Uh oh!

openshift-bot commented May 14, 2020

Uh oh!

openshift-bot commented May 14, 2020

Uh oh!

openshift-bot commented May 14, 2020

Uh oh!

openshift-bot commented May 14, 2020

Uh oh!

openshift-bot commented May 14, 2020

Uh oh!

ashcrow commented May 14, 2020

Uh oh!

openshift-bot commented May 14, 2020

Uh oh!

openshift-bot commented Jun 1, 2020

Uh oh!

openshift-bot commented Jun 1, 2020

Uh oh!

openshift-bot commented Jun 1, 2020

Uh oh!

openshift-bot commented Jun 1, 2020

Uh oh!

openshift-bot commented Jun 1, 2020

Uh oh!

openshift-bot commented Jun 2, 2020

Uh oh!

openshift-bot commented Jun 2, 2020

Uh oh!

openshift-bot commented Jun 2, 2020

Uh oh!

openshift-bot commented Jun 2, 2020

Uh oh!

openshift-bot commented Jun 2, 2020

Uh oh!

openshift-bot commented Jun 2, 2020

Uh oh!

LorbusChris commented May 13, 2020 •

edited

Loading